-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pre dx devmode #2036
base: testing
Are you sure you want to change the base?
feat: Pre dx devmode #2036
Conversation
could do with patching with the whole remote dev extension pack but cba |
system_files/desktop/shared/usr/share/ublue-os/just/87-bazzite-devcontainers.just
Show resolved
Hide resolved
It might be worth visiting a vscode distrobox instead of layering it for the future. |
Agreed, the problem is viewing the host docker socket so it'd mean a few other steps, obviously in the -dx release it can be a regular package or maybe a bluefin dev could do the flatpak magic? |
@mowglixx I think I found one more issue. The .just files are imported manually in the Containerfile. So your custom ujust commands won't work until you add an entry there too |
thanks for pointing that out, would have missed that, I've been testing with Pushing the change now. |
I have a VM all set up, I'll test as soon as I get a chance. Probably tomorrow sometime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to test in a VM but everything looks good to me
Thanks, I've been meaning to do the just script for virt-manager today so I might end up doing it myself, I'll drop a message if i do and I'm going to take a look at the image building process for my own image, I've been admiring @HikariKnight 's personal image for a starting point, I've done passthrough before so was good to see some familiar commands in the place it should be. =D |
No need for anything virt-manager, it's a flatpak and already done the optimal way here. |
I'm going to give this a containerization pass later today, we want to avoid layers at all costs. After that I'll be happy to merge into testing. |
no no no, I meant I'm going to run the just script (I fresh installed the other day from cachyOS) to get virt manager all set up so might run the VM to test ^this further myself |
ah so this might end up being an early -dx build instead of the layers? |
echo was printing null vars from shell |
^ Here's docker as a container. I'm going to leave this PR open as a workshop for a potential best-solution for VSCode as well, may also end up being distrobox until DX. |
See #2035